smengcl commented on code in PR #4420:
URL: https://github.com/apache/ozone/pull/4420#discussion_r1145432350
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/OMRequestTestUtils.java:
##########
@@ -447,6 +447,7 @@ public static OmKeyInfo createOmKeyInfo(String volumeName,
String bucketName,
.setVolumeName(volumeName)
.setBucketName(bucketName)
.setKeyName(keyName)
+ .setFileName(keyName)
Review Comment:
Good catch. In the test cases they are the same. But in prod it will extract
the last element (just the file name):
https://github.com/apache/ozone/blob/3e83eb6800a269eafb6a77a63303a46ba5882e5c/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java#L698-L699
I will make the test helper more robust by wrapping it in
`OzoneFSUtils.getFileName()` just like the prod one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
