adoroszlai commented on code in PR #4453:
URL: https://github.com/apache/ozone/pull/4453#discussion_r1146259634
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java:
##########
@@ -1169,15 +1154,6 @@ public void setMaintenanceReplicaMinimum(int
replicaCount) {
)
private boolean push = true;
- @PostConstruct
- public void validate() {
- if (!(commandDeadlineFactor > 0) || (commandDeadlineFactor > 1)) {
- throw new IllegalArgumentException("command.deadline.factor is set to "
- + commandDeadlineFactor
- + " and must be greater than 0 and less than equal to 1");
- }
- }
Review Comment:
It turns out that `TestBlockDeletion` sets
`hdds.scm.replication.event.timeout`, so it also needs to set
`hdds.scm.replication.event.timeout.datanode.offset`:
https://github.com/apache/ozone/actions/runs/4500741901/jobs/7920269601?pr=4453#step:5:3559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
