duongkame opened a new pull request, #4461:
URL: https://github.com/apache/ozone/pull/4461

   ## What changes were proposed in this pull request?
   
   RocksObject leaks in snapshot.
   ```
   2023-03-23 09:44:20,288 [Finalizer] WARN  managed.ManagedRocksObjectUtils 
(ManagedRocksObjectUtils.java:assertClosed(54)) - RocksIterator is not closed 
properly
    StackTrace for unclosed instance: 
org.apache.hadoop.hdds.utils.db.managed.ManagedObject.<init>(ManagedObject.java:35)
   
org.apache.hadoop.hdds.utils.db.managed.ManagedRocksIterator.<init>(ManagedRocksIterator.java:28)
   
org.apache.hadoop.hdds.utils.db.managed.ManagedRocksIterator.managed(ManagedRocksIterator.java:32)
   
org.apache.hadoop.hdds.utils.db.RocksDatabase.newIterator(RocksDatabase.java:757)
   org.apache.hadoop.hdds.utils.db.RDBTable.iterator(RDBTable.java:167)
   org.apache.hadoop.hdds.utils.db.TypedTable.iterator(TypedTable.java:286)
   
org.apache.hadoop.ozone.om.SnapshotChainManager.loadFromSnapshotInfoTable(SnapshotChainManager.java:266)
   
org.apache.hadoop.ozone.om.SnapshotChainManager.<init>(SnapshotChainManager.java:63)
   
org.apache.hadoop.ozone.om.OmMetadataManagerImpl.start(OmMetadataManagerImpl.java:480)
   
org.apache.hadoop.ozone.om.OmMetadataManagerImpl.<init>(OmMetadataManagerImpl.java:319)
   
org.apache.hadoop.ozone.om.OzoneManager.instantiateServices(OzoneManager.java:747)
   org.apache.hadoop.ozone.om.OzoneManager.<init>(OzoneManager.java:628)
   org.apache.hadoop.ozone.om.OzoneManager.createOm(OzoneManager.java:713)
   
org.apache.hadoop.ozone.MiniOzoneHAClusterImpl$Builder.createOMService(MiniOzoneHAClusterImpl.java:518)
   
org.apache.hadoop.ozone.MiniOzoneHAClusterImpl$Builder.build(MiniOzoneHAClusterImpl.java:426)
   org.apache.hadoop.ozone.om.TestOmSnapshot.init(TestOmSnapshot.java:175)
   org.apache.hadoop.ozone.om.TestOmSnapshot.<init>(TestOmSnapshot.java:144) 
   ```
   
   ```
   2023-03-23 10:10:20,868 [Finalizer] WARN  managed.ManagedRocksObjectUtils 
(ManagedRocksObjectUtils.java:assertClosed(54)) - RocksIterator is not closed 
properly
    StackTrace for unclosed instance: 
org.apache.hadoop.hdds.utils.db.managed.ManagedObject.<init>(ManagedObject.java:35)
   
org.apache.hadoop.hdds.utils.db.managed.ManagedRocksIterator.<init>(ManagedRocksIterator.java:28)
   
org.apache.hadoop.ozone.om.snapshot.RocksDbPersistentList.iterator(RocksDbPersistentList.java:85)
   
org.apache.hadoop.ozone.om.snapshot.SnapshotDiffManager.addToReport(SnapshotDiffManager.java:658)
   
org.apache.hadoop.ozone.om.snapshot.SnapshotDiffManager.generateDiffReport(SnapshotDiffManager.java:612)
   
org.apache.hadoop.ozone.om.snapshot.SnapshotDiffManager.generateSnapshotDiffReport(SnapshotDiffManager.java:343)
   
org.apache.hadoop.ozone.om.snapshot.SnapshotDiffManager.getSnapshotDiffReport(SnapshotDiffManager.java:196)
   
org.apache.hadoop.ozone.om.OmSnapshotManager.getSnapshotDiffReport(OmSnapshotManager.java:455)
   org.apache.hadoop.ozone.om.OzoneManager.snapshotDiff(OzoneManager.java:4493)
   
org.apache.hadoop.ozone.protocolPB.OzoneManagerRequestHandler.snapshotDiff(OzoneManagerRequestHandler.java:1223)
   
org.apache.hadoop.ozone.protocolPB.OzoneManagerRequestHandler.handleReadRequest(OzoneManagerRequestHandler.java:300)
   
org.apache.hadoop.ozone.protocolPB.OzoneManagerProtocolServerSideTranslatorPB.submitReadRequestToOM(OzoneManagerProtocolServerSideTranslatorPB.java:223)
   
org.apache.hadoop.ozone.protocolPB.OzoneManagerProtocolServerSideTranslatorPB.processRequest(OzoneManagerProtocolServerSideTranslatorPB.java:177)
   
org.apache.hadoop.hdds.server.OzoneProtocolMessageDispatcher.processRequest(OzoneProtocolMessageDispatcher.java:87)
 
   ```
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-8251
   
   ## How was this patch tested?
   
   No more leak warnings when running `TestOmSnapshot` integration test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to