adoroszlai commented on code in PR #4456: URL: https://github.com/apache/ozone/pull/4456#discussion_r1147685540
########## hadoop-ozone/dist/src/main/compose/upgrade/README.md: ########## @@ -18,39 +18,60 @@ This directory contains cluster definitions and scripts for testing upgrades fro previous version, or to the local build of the code. It is designed to catch backwards incompatible changes made between an older release of Ozone and a later release (which may be the local build). -## IMPORTANT NOTES +## Quick Guide For Release Managers -1. Backwards Incompatibility - - These tests will not catch backwards incompatible changes against commits in between releases. - - Example: - 1. After 1.0.0, a change *c1* is made that is backwards compatible with 1.0.0. - 2. After *c1*, a new change *c2* is made that is also backwards compatible with 1.0.0 but backwards *incompatible* with *c1*. +- The whole test matrix of upgrading and downgrading to/from previous releases to the current code is too time consuming to do on every CI run. Instead we recommend release managers manually test the full matrix before each release, and let only the tests from the previous release to the current code be run in CI. - - This test suite will not raise an error for *c2*, because it only tests against the last release - (1.0.0), and not the last commit (*c1*). +1. Before the release, test the whole matrix of upgrades from the previous version to the version you are releasing. + - This is important manual verification that the release does not break backwards compatibility, and the results can be included in the release vote mailing thread. + - To do this, uncomment all lines that contain `run_test` in the *test.sh* file, and execute *test.sh* either locally or on GitHub actions. + +2. After the release is finished and its docker image is published, add the new version to the test matrix. + 1. Change the `OZONE_CURRENT_VERSION` variable to `OZONE_CURRENT_VERSION=<newly-released-version>`. + 2. Comment out all `run_test` lines in *test.sh*. + 3. Add a new line: `run_test ha non-rolling-upgrade <newly-released-version> "$OZONE_CURRENT_VERSION"` before the commented out lines. + +## Important Notes on Test Scope + +- These tests will not catch backwards incompatible changes against commits in between releases. + - Example: + 1. After 1.2.0, a change *c1* is made that is backwards compatible with 1.2.0. + 2. After *c1*, a new change *c2* is made that is also backwards compatible with 1.0.0 but backwards *incompatible* with *c1*. + + - This test suite will not raise an error for *c2*, because it only tests against the last release + (1.2.0), and not the last commit (*c1*). + +## Supported Versions + +Non-rolling upgrades and downgrades are supported from 1.1.0 to any later version. Note that 1.1.0 did not have the non-rolling upgrade framework, so things like preparing the OMs for upgrade and checking finalization status are not present in that version. Manual upgrade is the only supported upgrade option from 1.0.0 to 1.1.0. Review Comment: I think 1.1.0 is correct here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
