sodonnel commented on code in PR #4458:
URL: https://github.com/apache/ozone/pull/4458#discussion_r1147833255
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java:
##########
@@ -162,6 +167,15 @@ public ContainerBalancerTask(StorageContainerManager scm,
*/
public void run() {
try {
+ if (delayStart) {
+ long delayDuration = ozoneConfiguration.getTimeDuration(
+ "hdds.scm.wait.time.after.safemode.exit",
+ HddsConfigKeys.HDDS_SCM_WAIT_TIME_AFTER_SAFE_MODE_EXIT_DEFAULT,
+ TimeUnit.SECONDS);
+ LOG.info("ContainerBalancer will sleep for {} seconds before starting"
+
+ " balancing.", delayDuration);
+ Thread.sleep(Duration.ofSeconds(delayDuration).toMillis());
Review Comment:
Initially I thought the tests were going to have to wait for the sleep
interval before completing, which was wrong. I am happy with the code as it
stands now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
