swamirishi commented on PR #4376: URL: https://github.com/apache/ozone/pull/4376#issuecomment-1483230274
> Thanks for the patch @swamirishi. > > Making thinks generic is a good idea but it is not needed always (YAGNI). In this patch, you tried to make `ManagedSstFileIterator` and `MultipleSstFileIterator` generic. Which is not a bad idea if they were generic enough. Both of them are internal to `ManagedSstFileReader` and have defined type `String`. Making these generic is just making the code complex, instead of simplifying it. It would be great if you could simplify it. I actually made it generic, currently we are using the sst files & the tombstone entries as mere hints. But when we have to implement the optimal snapdiff calculation just using the delta files then we need other info & the just the key wouldn't be sufficient we would require the the objectId & the seqId from the SST file as well. That is why I made it generic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
