jojochuang commented on code in PR #4460:
URL: https://github.com/apache/ozone/pull/4460#discussion_r1148486036


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -78,6 +78,8 @@ public final class OmKeyInfo extends WithParentObjectId {
    */
   private List<OzoneAcl> acls;
 
+  private boolean isHsync;

Review Comment:
   @szetszwo what if we just have isHsync() that returns the field? And 
therefore no need to add one extra field.
   
   ```
   boolean isHsync() {
     return metadata.containsKey(OzoneConsts.HSYNC_CLIENT_ID);
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to