jojochuang commented on code in PR #4452: URL: https://github.com/apache/ozone/pull/4452#discussion_r1148486415
########## hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/OzonePathCapabilities.java: ########## @@ -0,0 +1,54 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.fs.ozone; + +import java.util.Optional; + +import org.apache.hadoop.fs.CommonPathCapabilities; +import org.apache.hadoop.fs.Path; + +import static org.apache.hadoop.fs.impl.PathCapabilitiesSupport.validatePathCapabilityArgs; + +/** + * Utility class to help implement {@code hasPathCapability} API in Ozone + * file system. + */ +public final class OzonePathCapabilities { + private OzonePathCapabilities() { + + } + + /** + * Common implementation of {@code hasPathCapability} for all ofs and o3fs. + * @param path path to check + * @param capability capability + * @return either a value to return or, if empty, a cue for the FS to + * pass up to its superclass. + */ + public static Optional<Boolean> hasPathCapability(final Path path, + final String capability) { + switch (validatePathCapabilityArgs(path, capability)) { + case CommonPathCapabilities.FS_ACLS: + case CommonPathCapabilities.FS_CHECKSUMS: + case CommonPathCapabilities.FS_SNAPSHOTS: Review Comment: createSnapshot() is implemented in BasicRootedOzoneFileSystem. But you're right. The rest of snapshot APIs are not supported yet. Once snapshot is supported, the path capability can be added. Also will need to update contract tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
