adoroszlai commented on PR #4389:
URL: https://github.com/apache/ozone/pull/4389#issuecomment-1485061518

   Thanks @Pochatkin for updating the patch.  The following failures still need 
to be fixed.
   
   Add new module in `jar-report.txt`:
   
   ```diff
   diff --git hadoop-ozone/dist/src/main/license/jar-report.txt 
hadoop-ozone/dist/src/main/license/jar-report.txt
   --- hadoop-ozone/dist/src/main/license/jar-report.txt
   +++ hadoop-ozone/dist/src/main/license/jar-report.txt
   @@ -214,6 +214,7 @@ share/ozone/lib/ozone-interface-storage.jar
    share/ozone/lib/ozone-manager.jar
    share/ozone/lib/ozone-reconcodegen.jar
    share/ozone/lib/ozone-recon.jar
   +share/ozone/lib/ozone-s3-secret-store.jar
    share/ozone/lib/ozone-s3gateway.jar
    share/ozone/lib/ozone-tools.jar
    share/ozone/lib/perfmark-api.jar
   ```
   
   Remove reference to non-existent exclude file for findbugs:
   
   ```diff
   diff --git hadoop-ozone/s3-secret-store/pom.xml 
hadoop-ozone/s3-secret-store/pom.xml
   --- hadoop-ozone/s3-secret-store/pom.xml
   +++ hadoop-ozone/s3-secret-store/pom.xml
   @@ -65,16 +65,4 @@
        </dependency>
      </dependencies>
    
   -  <build>
   -    <plugins>
   -      <plugin>
   -        <groupId>com.github.spotbugs</groupId>
   -        <artifactId>spotbugs-maven-plugin</artifactId>
   -        <configuration>
   -          <excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml
   -          </excludeFilterFile>
   -        </configuration>
   -      </plugin>
   -    </plugins>
   -  </build>
    </project>
   ```
   
   Fix findbugs failures:
   
   ```
   M D ST: Write to static field 
org.apache.hadoop.ozone.s3.remote.vault.VaultS3SecretStoreTest.failAuthCounter 
from instance method 
org.apache.hadoop.ozone.s3.remote.vault.VaultS3SecretStoreTest.testAuthFail()  
At VaultS3SecretStoreTest.java:[line 111]
   M D ST: Write to static field 
org.apache.hadoop.ozone.s3.remote.vault.VaultS3SecretStoreTest.failAuthCounter 
from instance method 
org.apache.hadoop.ozone.s3.remote.vault.VaultS3SecretStoreTest.testReAuth()  At 
VaultS3SecretStoreTest.java:[line 97]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to