sumitagrawl commented on code in PR #4459:
URL: https://github.com/apache/ozone/pull/4459#discussion_r1150279713
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStore.java:
##########
@@ -78,12 +79,34 @@ public class RDBStore implements DBStore {
*/
private final String dbCompactionLogDirName = "compaction-log";
+ // this is to track the total size of dbUpdates data since sequence
+ // number in request to avoid increase in heap memory.
+ private long maxDbUpdatesSizeThreshold;
+
@VisibleForTesting
public RDBStore(File dbFile, ManagedDBOptions options,
Set<TableConfig> families) throws IOException {
this(dbFile, options, new ManagedWriteOptions(), families,
new CodecRegistry(), false, 1000, null, false,
TimeUnit.DAYS.toMillis(1), TimeUnit.HOURS.toMillis(1));
+ this.maxDbUpdatesSizeThreshold = MAX_DB_UPDATES_SIZE_THRESHOLD;
Review Comment:
plz use common default value, do not use another default value 80 which will
create confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
