smengcl commented on PR #4466: URL: https://github.com/apache/ozone/pull/4466#issuecomment-1487719230
> Which tests exercise the native build? Can we extract them into separate check(s), and avoid the overhead on the critical path (`build -> acceptance`)? Hi Attila, I plan to upload a compiled JNI jar (with `-snapshot` version) to Apache repo. It would be compiled for Linux 64-bit only for now just to enable CI (plan to cross-compile like rocksdbjni jar later). Take a look at the diagram I just uploaded to the PR description. See if that looks reasonable. For now we don't have tests specifically for the Rocksdb tools JNI. @swamirishi will add some in the coming weeks. Filed HDDS-8306 for this. The only tests that would actually be using Rocksdb tools native right now are those SnapDiff tests (e.g. `TestOmSnapshot#testSnapDiff`). Those tests would automatically use the `rocksdb_sst_dump` tool when that is available. Obviously we would also need to parameterize the SnapDiff tests e.g. to force them to use the sst_dump tool in one set of params, in order to make sure the tool is working as intended. Filed HDDS-8307 for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
