ArafatKhan2198 commented on code in PR #4406:
URL: https://github.com/apache/ozone/pull/4406#discussion_r1151252200
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestEndpoints.java:
##########
@@ -366,25 +370,19 @@ public void setUp() throws Exception {
} catch (Exception ex) {
Assertions.fail(ex.getMessage());
}
-
// Write Data to OM
-
// A sample volume (sampleVol) and a bucket (bucketOne) is already created
// in AbstractOMMetadataManagerTest.
// Create a new volume and bucket and then write keys to the bucket.
String volumeKey = reconOMMetadataManager.getVolumeKey("sampleVol2");
OmVolumeArgs args =
OmVolumeArgs.newBuilder()
- .setVolume("sampleVol2")
- .setAdminName("TestUser")
- .setOwnerName("TestUser")
- .build();
+ .setVolume("sampleVol2").setAdminName("TestUser")
+ .setOwnerName("TestUser").build();
reconOMMetadataManager.getVolumeTable().put(volumeKey, args);
OmBucketInfo bucketInfo = OmBucketInfo.newBuilder()
- .setVolumeName("sampleVol2")
- .setBucketName("bucketOne")
- .build();
+ .setVolumeName("sampleVol2").setBucketName("bucketOne").build();
Review Comment:
Got It!
Thanks weichu I have made the changes
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestEndpoints.java:
##########
@@ -366,25 +370,19 @@ public void setUp() throws Exception {
} catch (Exception ex) {
Assertions.fail(ex.getMessage());
}
-
// Write Data to OM
-
// A sample volume (sampleVol) and a bucket (bucketOne) is already created
// in AbstractOMMetadataManagerTest.
// Create a new volume and bucket and then write keys to the bucket.
String volumeKey = reconOMMetadataManager.getVolumeKey("sampleVol2");
OmVolumeArgs args =
OmVolumeArgs.newBuilder()
- .setVolume("sampleVol2")
- .setAdminName("TestUser")
- .setOwnerName("TestUser")
- .build();
+ .setVolume("sampleVol2").setAdminName("TestUser")
+ .setOwnerName("TestUser").build();
reconOMMetadataManager.getVolumeTable().put(volumeKey, args);
OmBucketInfo bucketInfo = OmBucketInfo.newBuilder()
- .setVolumeName("sampleVol2")
- .setBucketName("bucketOne")
- .build();
+ .setVolumeName("sampleVol2").setBucketName("bucketOne").build();
Review Comment:
Got It!
Thanks @WeisonWei I have made the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
