sadanand48 commented on code in PR #4419:
URL: https://github.com/apache/ozone/pull/4419#discussion_r1151490932
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -180,6 +182,28 @@ public OmSnapshot load(@Nonnull String snapshotTableKey)
// see if the snapshot exists
snapshotInfo = getSnapshotInfo(snapshotTableKey);
+ // Block snapshot from loading when it is no longer active e.g.
DELETED,
+ // unless this is called from SnapshotDeletingService.
+ // TODO: [SNAPSHOT] However, snapshotCache.get() from other requests
Review Comment:
Yeah right, like you commented we could also try with the separate cache for
SDS access but I guess it can be done in another jira. Thanks @smengcl for
explaining.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
