fapifta commented on PR #4380: URL: https://github.com/apache/ozone/pull/4380#issuecomment-1488502985
`HASecurityUtils#initializeSecurity` iscalled only from init or bootstrap, after which SCM does not remain running, so even if there is a client created in that phase the certificate should not (in regular circumstances) expire within the grace period, so the one background thread that is created does not remain live, once the process exits within (in regular circumstances) a few seconds. Though we can close the client in this method it does not really matter. Similarly in `TestContainerServer` the client is created in a method that is annotated with `@BeforeAll` and then it is passed to gRPC server creation calls, where it is not re-created, so again we can close it there, but it does not really matter as we do not have parallel test execution. I have added the closure to these cases as well, to be consistent with the rest. Will commit it with the fix for the integration test failure which is related. Thank you for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
