hemantk-12 commented on code in PR #4492:
URL: https://github.com/apache/ozone/pull/4492#discussion_r1152259691
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStore.java:
##########
@@ -213,6 +214,7 @@ public void close() throws IOException {
RDBMetrics.unRegister();
checkPointManager.close();
+ IOUtils.closeQuietly(rocksDBCheckpointDiffer);
Review Comment:
Sorry If I was not clear. I meant
[IOUtils.closeQuietly()](https://github.com/apache/ozone/blob/0f1ba3f8a38e0d51bc402284607ac73fb1c116f9/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/IOUtils.java#L79)
swallows the exception if there is any. Yes, `rocksDBCheckpointDiffer.close()`
doesn't throw any exception.
Why didn't we use `rocksDBCheckpointDiffer.close()` directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
