sodonnel commented on code in PR #4496:
URL: https://github.com/apache/ozone/pull/4496#discussion_r1152482688
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java:
##########
@@ -315,14 +315,8 @@ private int processMissingIndexes(
sourceDatanodesWithIndex, selectedDatanodes,
int2byte(missingIndexes),
repConfig);
- replicationManager.sendDatanodeCommand(reconstructionCommand,
- container, selectedDatanodes.get(0));
- // For each index that is going to be reconstructed with this command,
- // adjust the replica count to reflect the pending operation.
- for (int i = 0; i < missingIndexes.size(); i++) {
Review Comment:
This, I believe, was an existing bug in the handler. The pendingOps are
adjusted via the `replicationManager.sendDatanodeCommand()`, so they were being
adjust here and then again in RM. I am not sure if that would have caused a
problem or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
