kaijchen commented on code in PR #4503: URL: https://github.com/apache/ozone/pull/4503#discussion_r1153968625
########## hadoop-ozone/dist/src/shell/conf/db.ini.template: ########## @@ -0,0 +1,25 @@ +# This is a RocksDB option file. +# +# For detailed file format spec, please refer to the example file +# examples/rocksdb_option_file_example.ini in +# https://github.com/facebook/rocksdb +# +# Below is the server name and corresponding RocksDB option file name: +# OM om.db.ini +# SCM scm.db.ini +# DN dn-crl.db.ini +# +# Below is an example of a RocksDB options file: + +[DBOptions] + max_background_flushes=2 + compaction_readahead_size=4194304 + bytes_per_sync=1048576 + max_background_compactions=4 + max_background_jobs=48 + create_missing_column_families=true + create_if_missing=true + +[CFOptions "default"] + +[TableOptions/BlockBasedTable "default"] Review Comment: Add a newline before EOF. ########## hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBConfigFromFile.java: ########## @@ -120,7 +120,7 @@ public static ManagedDBOptions readFromFile(String dbFileName, Preconditions.checkNotNull(cfDescs); Preconditions.checkArgument(cfDescs.size() > 0); - //TODO: Add Documentation on how to support RocksDB Mem Env. + // Documentation on how to support RocksDB Mem Env: see HDDS-8331. Review Comment: Maybe direct link is better? ```suggestion // Documentation on how to support RocksDB Mem Env: // see hadoop-hdds/docs/content/recipe/RocksdbOptions.md ``` ########## hadoop-hdds/docs/content/recipe/RocksdbOptions.zh.md: ########## @@ -0,0 +1,55 @@ +--- +title: 自定义Rocksdb参数 +linktitle: Rocksdb Options +summary: OM/SCM/DN使用的自定义的Rocksdb参数 +--- +<!--- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +Ozone使用的rocksdb参数大多数为默认参数。本页介绍如何通过配置文件来使用自定义的rocksdb参数。 + +## 使用Rocksdb配置文件 + +将对应的配置文件`file`放在OZONE的配置目录`$OZONE_DIR/etc/hadoop`下，然后重启服务即可。以下列出了OM/SCM/DN默认加载的rocksdb配置文件名。 + +服务 | 文件名 +----|--------- +OM | om.db.ini +SCM | scm.db.ini +DN | dn-crl.db.ini + +Rocksdb配置文件格式请参考：[rocksdb_option_file_example.ini](https://github.com/facebook/rocksdb/blob/main/examples/rocksdb_option_file_example.ini) + +## 验证配置文件生效 + +查看rocksdb目录下的`OPTIONS-xxxxxx`相应配置项是否符合预期。例如，OM的配置文件`$OZONE_DIR/etc/hadoop/om.db.ini`如下：(修改`max_background_flushes=4`) + +```ini +[DBOptions] + max_background_flushes=4 + compaction_readahead_size=4194304 + bytes_per_sync=1048576 + max_background_compactions=4 + max_background_jobs=48 + create_missing_column_families=true + create_if_missing=true + +[CFOptions "default"] + +[TableOptions/BlockBasedTable "default"] +``` +重启OM后，查看OM的rocksdb目录（`${DBDATA}/om.db`）下`OPTIONS-xxxxxx`内容，`max_background_flushes=4`表明配置生效。 Review Comment: Please add a space between Chinese characters and English characters. For example: ``` 将对应的配置文件 `file` 放在OZONE的配置目录 `$OZONE_DIR/etc/hadoop` 下，然后重启服务即可。以下列出了 OM/SCM/DN 默认加载的 rocksdb 配置文件名。 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
