adoroszlai commented on PR #4523: URL: https://github.com/apache/ozone/pull/4523#issuecomment-1494687799
Thanks @ivanzlenko for the patch. Please take a look at failed checks: Checkstyle: https://github.com/ivanzlenko/ozone/actions/runs/4598937885/jobs/8123679899#step:6:527 ``` hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/S3GatewayHttpServer.java 54: Line is longer than 80 characters (found 92). 58: Line is longer than 80 characters (found 118). 61: Line is longer than 80 characters (found 99). 63: Line is longer than 80 characters (found 87). 69: Line is longer than 80 characters (found 91). 71: Line is longer than 80 characters (found 100). hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3secret/package-info.java 1: File does not end with a newline. hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3secret/S3SecretEndpointBase.java 21: Unused import - org.apache.hadoop.hdds.conf.OzoneConfiguration. 28: Unused import - org.apache.hadoop.security.HadoopKerberosName. 33: Unused import - java.io.IOException. hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/ServletElementsFactory.java 7: Missing a Javadoc comment. 9: Line is longer than 80 characters (found 96). 20: Line is longer than 80 characters (found 112). hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/BaseHttpServer.java 261: First sentence should end with a period. 268: Line is longer than 80 characters (found 91). 268: 'name' hides a field. ``` Findbugs: https://github.com/ivanzlenko/ozone/actions/runs/4598937885/jobs/8123680269#step:6:2286 ``` M P UrF: Unread field: org.apache.hadoop.hdds.server.http.HttpServer2$Builder.keytabConfKey At HttpServer2.java:[line 356] M P UrF: Unread field: org.apache.hadoop.hdds.server.http.HttpServer2$Builder.usernameConfKey At HttpServer2.java:[line 351] ``` Also, license header is needed in all files. Example: https://github.com/apache/ozone/blob/050d58b6d0f59e251519a4108930fa78f850b231/hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/scm/net/TestNetUtils.java#L1-L17 Rat check shows it's missing from `ServletElementsFactory`: https://github.com/ivanzlenko/ozone/actions/runs/4598937885/jobs/8123680406#step:6:815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
