jojochuang commented on code in PR #4443:
URL: https://github.com/apache/ozone/pull/4443#discussion_r1156466572


##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -405,6 +405,7 @@ message ContainerReplicaHistoryProto {
     required int64 firstSeenTime = 2;
     required int64 lastSeenTime = 3;
     required int64 bcsId = 4;
+    required string state = 5;

Review Comment:
   It would break rolling upgrade, or when recon and SCM are in different 
versions.
   
   I see that rolling upgrade is not yet a thing, so I am okay with it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to