adoroszlai commented on code in PR #4517:
URL: https://github.com/apache/ozone/pull/4517#discussion_r1156802299
##########
hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/security/token/TestOzoneBlockTokenIdentifier.java:
##########
@@ -260,15 +259,15 @@ public void testAsymmetricTokenPerf() throws
NoSuchAlgorithmException,
}
@Test
- public void testSymmetricTokenPerf() {
+ void testSymmetricTokenPerf() {
String hmacSHA1 = "HmacSHA1";
String hmacSHA256 = "HmacSHA256";
testSymmetricTokenPerfHelper(hmacSHA1, 64);
testSymmetricTokenPerfHelper(hmacSHA256, 1024);
}
- public void testSymmetricTokenPerfHelper(String hmacAlgorithm, int keyLen) {
+ private void testSymmetricTokenPerfHelper(String hmacAlgorithm, int keyLen) {
Review Comment:
No, the problem is fixed by actually using the "useless object" here:
```
LOG.info("Average token sign time with {}({} symmetric key) is {} ns",
hmacAlgorithm, keyLen, duration / tokenPasswordSym.size());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
