adoroszlai commented on code in PR #4489:
URL: https://github.com/apache/ozone/pull/4489#discussion_r1156909595
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/TestContainerPlacementFactory.java:
##########
@@ -163,10 +163,13 @@ public void testRackAwarePolicy() throws IOException {
}
@Test
- public void testDefaultPolicy() throws IOException {
+ public void testRackAwareContainerPolicy() throws IOException {
+ conf.set(ScmConfigKeys.OZONE_SCM_CONTAINER_PLACEMENT_IMPL_KEY,
+ SCMContainerPlacementRackAware.class.getName());
PlacementPolicy policy = ContainerPlacementPolicyFactory
.getPolicy(conf, null, null, true, null);
- Assertions.assertSame(SCMContainerPlacementRandom.class,
policy.getClass());
+ Assertions.assertSame(SCMContainerPlacementRackAware.class,
+ policy.getClass());
}
Review Comment:
I would have preferred keeping the intention of this test: testing default
setting. Sorry for not noticing this earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
