dombizita commented on code in PR #4519:
URL: https://github.com/apache/ozone/pull/4519#discussion_r1156939996
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json:
##########
@@ -1,5 +1,6 @@
{
"clusterState": {
+ "deletedDirs": 1200,
Review Comment:
what is `deletedDirs`? I don't see it used anywhere else and also can't see
where it is coming from
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx:
##########
@@ -227,6 +231,9 @@ export class Overview extends
React.Component<Record<string, object>, IOverviewS
<Col xs={24} sm={18} md={12} lg={12} xl={6}>
<OverviewCard loading={loading} title='Keys'
data={keys.toString()} icon='file-text'/>
</Col>
+ <Col xs={24} sm={18} md={12} lg={12} xl={6}>
+ <OverviewCard loading={loading} title='Pending key Deletions'
data={deletedKeys.toString()} icon='delete'/>
Review Comment:
nit
```suggestion
<OverviewCard loading={loading} title='Pending Key Deletions'
data={deletedKeys.toString()} icon='delete'/>
```
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json:
##########
@@ -13,7 +14,8 @@
"openContainers": 5,
"volumes": 5,
"buckets": 156,
- "keys": 253000
+ "keys": 253000,
+ "deletedKeys": 1000
Review Comment:
maybe use the `pendingDeleteKeys` here as well, so the naming won't confuse
anyone reading the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
