[ 
https://issues.apache.org/jira/browse/HDDS-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708515#comment-17708515
 ] 

Ethan Rose commented on HDDS-8305:
----------------------------------

Thanks for looking into this [~pifta]. I will investigate this improvement.

> Consider removing load.sh from Upgrade acceptance test code
> -----------------------------------------------------------
>
>                 Key: HDDS-8305
>                 URL: https://issues.apache.org/jira/browse/HDDS-8305
>             Project: Apache Ozone
>          Issue Type: Improvement
>            Reporter: István Fajth
>            Assignee: Ethan Rose
>            Priority: Major
>
> As part of the review for HDDS-6633 there is some further improvement 
> proposed, this JIRA is to track that, in order to get HDDS-6633 in.
> All three internal upgrade acceptance test folders are having a load.sh, and 
> it is almost identical, there are only two differences, the compose file that 
> is being exported, and the data directories that are created.
> I think it does not make any harm to create all the data directories that 
> might be used, and the compose file is something we can determine the 
> location of in the testlib.sh's run_test method where these files are being 
> sourced.
> So I propose to move this logic out from the load.sh files to the run_test 
> method or to a separate method in the testlib.sh.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to