[GitHub] [ozone] siddhantsangwan opened a new pull request, #4542: HDDS-8170. Let ContainerBalancer consider EC containers for balancing

Wed, 05 Apr 2023 05:35:55 -0700 


siddhantsangwan opened a new pull request, #4542:
URL: https://github.com/apache/ozone/pull/4542

   ## What changes were proposed in this pull request?
   
   This PR enables balancing EC containers in `ContainerBalancer`. Since 
`MoveManager` has been integrated with ContainerBalancer now, we can support 
balancing EC containers.
   
   Changes include:
   1. Exclude EC containers from balancing in 
`ContainerBalancerSelectionCriteria` only if Legacy RM is enabled.
   2. Add some `DEBUG` logs in `MoveManager`.
   3. Fix a small bug in `ContainerBalancer` where it was logging a `Duration` 
instead of the long value of a config.
   4. Update the setup in `TestContainerBalancerTask` to also create EC 
containers along with the RATIS containers it was already creating. Change some 
tests accordingly.
   5. Disable Legacy RM in `TestContainerBalancerTask`, except in specific 
tests where we're testing both Legacy RM and `MoveManager`.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-8170
   
   ## How was this patch tested?
   
   Green CI in my fork: 
https://github.com/siddhantsangwan/ozone/actions/runs/4617711869
   
   Added a UT and did some docker-compose manual testing.
   
   Screenshot showing an EC container with id 6 and replica index 4 being 
replicated by balancer:
   <img width="1476" alt="replicate_ec" 
src="https://user-images.githubusercontent.com/34305492/230081459-f57c2c12-c633-4d76-b5e4-3ff0abbc0824.png";>
   
   Screenshot showing the same container being deleted:
   <img width="1476" alt="delete_ec" 
src="https://user-images.githubusercontent.com/34305492/230081605-c394a307-63f9-41e2-ba11-b0fe333ebbe3.png";>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to