prashantpogde commented on code in PR #4491:
URL: https://github.com/apache/ozone/pull/4491#discussion_r1158873467
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java:
##########
@@ -1282,4 +1285,19 @@ public String createSnapshot(String pathStr, String
snapshotName)
ofsPath.getBucketName(),
snapshotName);
}
+
+ @Override
+ public SnapshotDiffReport getSnapshotDiffReport(Path snapshotDir,
+ String fromSnapshot, String toSnapshot)
+ throws IOException, InterruptedException {
+ OFSPath ofsPath = new OFSPath(snapshotDir, config);
+ SnapshotDiffResponse snapshotDiffResponse = null;
+ do {
+ snapshotDiffResponse = objectStore.snapshotDiff(ofsPath.getVolumeName(),
+ ofsPath.getBucketName(), fromSnapshot, toSnapshot, "", -1, false);
+ Thread.sleep(snapshotDiffResponse.getWaitTimeInMs());
+ } while (snapshotDiffResponse.getJobStatus() != DONE);
Review Comment:
I guess waiting here should be enough. The response returned is paginated,
so we should be able to handle all the pages returned by the reponse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
