fapifta commented on code in PR #4493: URL: https://github.com/apache/ozone/pull/4493#discussion_r1159459957
########## hadoop-ozone/dist/src/main/compose/ozonesecure-ha/docker-config-scm4: ########## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +OZONE-SITE.XML_ozone.scm.nodes.scmservice=scm1,scm2,scm3,scm4 +OZONE-SITE.XML_ozone.scm.address.scmservice.scm4=scm4.org Review Comment: Nit: no newline at and of file, there was an effort to have newlines at the end of all files, it is not enforce for non-Java files, but it would be nice to keep the convention. ########## hadoop-ozone/dist/src/main/smoketest/scmha/primordial-scm.robot: ########## @@ -0,0 +1,50 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +*** Settings *** +Documentation Smoketest ozone cluster startup +Library OperatingSystem +Library BuiltIn +Resource ../commonlib.robot +Test Timeout 5 minutes + +*** Variables *** + +** Keywords *** +Get SCM Node Count + ${result} = Execute ozone admin scm roles --service-id=scmservice + LOG ${result} + ${scm_count} = Get Line Count ${result} + [return] ${scm_count} + +*** Test Cases *** +Verify SCM Count + ${scm_count} = Get SCM Node Count + LOG SCM Instance Count: ${scm_count} + ${scm_count} = Convert To String ${scm_count} + Should be Equal 4 ${scm_count} + +Transfer Leader to SCM4 + ${result} = Execute ozone admin scm roles --service-id=scmservice + LOG ${result} + ${scm4_line} = Get Lines Containing String ${result} scm4.org + ${scm4_split} = Split String ${scm4_line} : + ${scm4_uuid} = Strip String ${scm4_split[3]} + + ${result} = Execute ozone admin scm transfer --service-id=scmservice -n ${scm4_uuid} + LOG ${result} + Should Contain ${result} Transfer leadership successfully + Review Comment: Should we assert on the Issuer of the 4th SCM's certificate as well, to ensure that it is signed by one of the subordinate CA certificates? I think, if SCM is up, operational, and can be the leader, that ensures it has a valid certificate, but we would like to ensure that later the certificate is signed by an other SCM's sub-CA certificate, and other changes don't change this behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
