neils-dev commented on code in PR #4518:
URL: https://github.com/apache/ozone/pull/4518#discussion_r1160934599
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMCertStore.java:
##########
@@ -142,7 +144,7 @@ public Optional<Long> revokeCertificates(
CRLReason reason,
Date revocationTime,
CRLApprover crlApprover)
- throws IOException {
+ throws IOException, TimeoutException {
Review Comment:
The interface for `revokeCertificates` needs to be modified if used. The
`CRLApprover `object should not be passed in the ratis transaction, instead
what is processed should be redesigned to be pre-signed by the CA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
