adoroszlai commented on PR #4539: URL: https://github.com/apache/ozone/pull/4539#issuecomment-1501504137
Thanks @siddhantsangwan for taking a look. > I'm wondering if `getRequiredRackCount(replicas)` should return 1 instead of 2 in this case? Good point, it might be a more complete fix, and `SCMContainerPlacementRackAware` already does that. Also, there are a few places using `min(numRacks, requiredRacks)`, so we might as well get rid of those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
