adoroszlai commented on code in PR #4537:
URL: https://github.com/apache/ozone/pull/4537#discussion_r1161670806
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java:
##########
@@ -105,7 +105,8 @@ public OMRequest preExecute(OzoneManager ozoneManager)
throws IOException {
return getOmRequest().toBuilder()
.setCommitKeyRequest(commitKeyRequest.toBuilder()
- .setKeyArgs(newKeyArgs)).setUserInfo(getUserInfo()).build();
+ .setKeyArgs(newKeyArgs))
+ .setUserInfo(getUserIfNotExists(ozoneManager)).build();
Review Comment:
@sumitagrawl `OMGetDelegationTokenRequest` and similar requests call
`super.preExecute` at the start of the method to obtain the `OMRequest` updated
by parent logic, then update with local changes as necessary. It is not
optimal, due to duplicate builder conversion, but it is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
