sumitagrawl commented on code in PR #4505:
URL: https://github.com/apache/ozone/pull/4505#discussion_r1165631479
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconStorageContainerManagerFacade.java:
##########
@@ -246,9 +241,15 @@ public
ReconStorageContainerManagerFacade(OzoneConfiguration conf,
IncrementalContainerReportHandler icrHandler =
new ReconIncrementalContainerReportHandler(nodeManager,
containerManager, scmContext);
+ long timeDuration = conf.getTimeDuration(
+ OzoneConfigKeys.OZONE_SCM_CLOSE_CONTAINER_WAIT_DURATION,
+ OzoneConfigKeys.OZONE_SCM_CLOSE_CONTAINER_WAIT_DURATION_DEFAULT
+ .getDuration(), TimeUnit.MILLISECONDS);
+ leaseManager = new LeaseManager<>("Lease Manager", timeDuration);
CloseContainerEventHandler closeContainerHandler =
new CloseContainerEventHandler(
- pipelineManager, containerManager, scmContext);
+ pipelineManager, containerManager, scmContext,
+ leaseManager, timeDuration);
Review Comment:
@errose28 Its handled by defining leaseManager as nullable in constructor
and passing it null for recon
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java:
##########
@@ -1746,6 +1766,13 @@ public ContainerManager getContainerManager() {
return containerManager;
}
+ /**
+ * Returns SCM lease manager.
+ */
+ public LeaseManager getLeaseManager() {
+ return leaseManager;
+ }
Review Comment:
Updated...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
