GeorgeJahad commented on code in PR #4294:
URL: https://github.com/apache/ozone/pull/4294#discussion_r1166167855
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java:
##########
@@ -208,6 +209,31 @@ public void notifyConfigurationChanged(long term, long
index,
ozoneManager.updatePeerList(newPeerIds);
}
+ /**
+ * Called to notify state machine about the snapshot install result.
+ * Used to trigger the cleanup of candidate DB dir.
+ * @param result InstallSnapshotResult
+ * @param snapshotIndex the index of installed snapshot
+ * @param peer the peer which fini
+ */
+ @Override
+ public void notifySnapshotInstalled(RaftProtos.InstallSnapshotResult result,
Review Comment:
I'm unfamiliar with this part of the state machine. Can you a little more
info about when this method gets invoked by the state machine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
