whbing commented on PR #4559:
URL: https://github.com/apache/ozone/pull/4559#issuecomment-1510385908

   The latest commits fix:
   1. Fix om snapshot NPE:
   ```java
   java.lang.NullPointerException
           at 
org.apache.hadoop.ozone.om.KeyManagerImpl.checkAccess(KeyManagerImpl.java:928)
           at 
org.apache.hadoop.ozone.security.acl.OzoneNativeAuthorizer.checkAccess(OzoneNativeAuthorizer.java:154)
           at 
org.apache.hadoop.ozone.om.OmMetadataReader.checkAcls(OmMetadataReader.java:497)
           at 
org.apache.hadoop.ozone.om.OmMetadataReader.checkAcls(OmMetadataReader.java:484)
           at 
org.apache.hadoop.ozone.om.OzoneAclUtils.checkAllAcls(OzoneAclUtils.java:121)
           at 
org.apache.hadoop.ozone.om.OmMetadataReader.checkAcls(OmMetadataReader.java:446)
           at 
org.apache.hadoop.ozone.om.OmMetadataReader.lambda$3(OmMetadataReader.java:203)
           at 
org.apache.hadoop.util.MetricUtil.captureLatencyNs(MetricUtil.java:47)
           at 
org.apache.hadoop.ozone.om.OmMetadataReader.getKeyInfo(OmMetadataReader.java:202)
           at 
org.apache.hadoop.ozone.om.OmSnapshot.getKeyInfo(OmSnapshot.java:101)
           at 
org.apache.hadoop.ozone.om.OzoneManager.getKeyInfo(OzoneManager.java:2798)
           at 
org.apache.hadoop.ozone.protocolPB.OzoneManagerRequestHandler.getKeyInfo(OzoneManagerRequestHandler.java:549)
   ```
   2.  Fix test failures and add test cases in link.robot
   3.  Fix resolveBucketLink loop checkAcls problem:
   ```java
           at 
org.apache.hadoop.ozone.security.acl.OzoneNativeAuthorizer.checkAccess(OzoneNativeAuthorizer.java:142)
           at 
org.apache.hadoop.ozone.om.OmMetadataReader.checkAcls(OmMetadataReader.java:497)
           at 
org.apache.hadoop.ozone.om.OzoneManager.checkAcls(OzoneManager.java:2531)
           at 
org.apache.hadoop.ozone.om.OzoneManager.resolveBucketLink(OzoneManager.java:4162)
           at 
org.apache.hadoop.ozone.om.OzoneManager.resolveBucketLink(OzoneManager.java:4114)
           at 
org.apache.hadoop.ozone.om.OzoneManager.resolveBucketLink(OzoneManager.java:4101)
           at 
org.apache.hadoop.ozone.om.BucketManagerImpl.checkAccess(BucketManagerImpl.java:157)
           at 
org.apache.hadoop.ozone.security.acl.OzoneNativeAuthorizer.checkAccess(OzoneNativeAuthorizer.java:142)
           at 
org.apache.hadoop.ozone.om.OmMetadataReader.checkAcls(OmMetadataReader.java:497)
           at 
org.apache.hadoop.ozone.om.OzoneManager.checkAcls(OzoneManager.java:2531)
           at 
org.apache.hadoop.ozone.om.OzoneManager.resolveBucketLink(OzoneManager.java:4162)
           at 
org.apache.hadoop.ozone.om.OzoneManager.resolveBucketLink(OzoneManager.java:4114)
           at 
org.apache.hadoop.ozone.om.OzoneManager.resolveBucketLink(OzoneManager.java:4101)
           at 
org.apache.hadoop.ozone.om.BucketManagerImpl.checkAccess(BucketManagerImpl.java:157)
           at 
org.apache.hadoop.ozone.security.acl.OzoneNativeAuthorizer.checkAccess(OzoneNativeAuthorizer.java:142)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to