fapifta commented on code in PR #4546:
URL: https://github.com/apache/ozone/pull/4546#discussion_r1169327699
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm.js:
##########
Review Comment:
Indentation of this file is pretty much messed up, please fix it. Please
keep the 4 spaces as default indentation as with the rest of the file.
##########
hadoop-hdds/framework/src/main/resources/webapps/static/ozone.css:
##########
@@ -53,7 +53,36 @@ body {
.sortorder.reverse:after {
content: '\25bc'; // BLACK DOWN-POINTING TRIANGLE
}
-
+.sorting:after {
Review Comment:
These changes, and a couple of related changes seem to be something that
does not belong to this JIRA, and fixing something that is not mentioned here.
It is great to fix this thing, but for clarity I think anything that is
related to how ordering elements are being rendered should be in a separate
JIRA describing the problem, and then fixed in a separate PR, so later on we
can track and understand what has happened and why, and we can more easily find
the track records of a particular problem.
If I misunderstand it, and this change is required to deliver the DataNode
ports from the backend to the frontend, and then show DataNode WebUI URLs
properly, then please correct me, if I am right, please file a separate JIRA
for this and add the improvement for the sorting UI and logic separately from
adding the URLs.
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html:
##########
@@ -45,23 +45,24 @@ <h2>Node Status</h2>
</div>
<table class="table table-bordered table-striped col-md-6">
<thead>
- <tr>
- <th ng-click = "columnSort('hostname')"
class="nodeStausInfo"><span ng-class = "{'sorting' : (columnName !=
'hostname'), 'sortasc' : (columnName == 'hostname' && !reverse),
- 'sortdesc':(columnName == 'hostname'
&& reverse)}">HostName</span></th>
- <th ng-click = "columnSort('opstate')" class="nodeStausInfo"
><span ng-class="{'sorting' : (columnName != 'opstate'), 'sortasc' :
(columnName == 'opstate' && !reverse),
- 'sortdesc':(columnName == 'opstate' &&
reverse)}">Operational State</span></th>
- <th ng-click = "columnSort('comstate')" class="nodeStausInfo">
<span ng-class="{'sorting' : (columnName != 'comstate'), 'sortasc' :
(columnName == 'comstate' && !reverse),
- 'sortdesc':(columnName == 'comstate'
&& reverse)}">Commisioned State</span> </th>
- </tr>
+ <tr>
Review Comment:
Here again, I am not sure what is causing the indentation change, probably 4
spaces exchanged to tabs, or vice versa, but we should stick to keep 4 spaces
as basic indentation as it is in the rest of the file.
Also these changes seem to be related again to fixing things with sorting,
so these as well should go under a separate JIRA in a separate PR.
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html:
##########
@@ -45,23 +45,24 @@ <h2>Node Status</h2>
</div>
<table class="table table-bordered table-striped col-md-6">
<thead>
- <tr>
- <th ng-click = "columnSort('hostname')"
class="nodeStausInfo"><span ng-class = "{'sorting' : (columnName !=
'hostname'), 'sortasc' : (columnName == 'hostname' && !reverse),
- 'sortdesc':(columnName == 'hostname'
&& reverse)}">HostName</span></th>
- <th ng-click = "columnSort('opstate')" class="nodeStausInfo"
><span ng-class="{'sorting' : (columnName != 'opstate'), 'sortasc' :
(columnName == 'opstate' && !reverse),
- 'sortdesc':(columnName == 'opstate' &&
reverse)}">Operational State</span></th>
- <th ng-click = "columnSort('comstate')" class="nodeStausInfo">
<span ng-class="{'sorting' : (columnName != 'comstate'), 'sortasc' :
(columnName == 'comstate' && !reverse),
- 'sortdesc':(columnName == 'comstate'
&& reverse)}">Commisioned State</span> </th>
- </tr>
+ <tr>
+ <th ng-click = "columnSort('hostname')" class="nodeStausInfo"><span
ng-class = "{'sorting' : (columnName != 'hostname'), 'sortasc' : (columnName ==
'hostname' && reverse),
+ 'sortdesc':(columnName == 'hostname'
&& !reverse)}">HostName</span></th>
+ <th ng-click = "columnSort('opstate')" class="nodeStausInfo" ><span
ng-class="{'sorting' : (columnName != 'opstate'), 'sortasc' : (columnName ==
'opstate' && reverse),
+ 'sortdesc':(columnName == 'opstate' &&
!reverse)}">Operational State</span></th>
+ <th ng-click = "columnSort('comstate')" class="nodeStausInfo"> <span
ng-class="{'sorting' : (columnName != 'comstate'), 'sortasc' : (columnName ==
'comstate' && reverse),
+ 'sortdesc':(columnName == 'comstate'
&& !reverse)}">Commisioned State</span> </th>
+ </tr>
</thead>
<tbody>
<tr ng-repeat="typestat in
nodeStatus|filter:search|orderBy:columnName:reverse">
- <td>{{typestat.hostname}}</td>
+ <td><a
href="{{typestat.portval.toLowerCase()}}://{{typestat.hostname}}:{{typestat.portno}}"
target="_blank">{{typestat.hostname}}</a></td>
<td>{{typestat.opstate}}</td>
<td>{{typestat.comstate}}</td>
- </tr>
+ </tr>
Review Comment:
Incorrect indentation change, please keep 4 spaces as for the rest of the
file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
