nandakumar131 commented on PR #4563: URL: https://github.com/apache/ozone/pull/4563#issuecomment-1513410607
> Why was cluster ID validation for SCM removal added in https://github.com/apache/ozone/pull/4358 ? None of the other decommission requests, or any requests that I can think of, require the user to specify the cluster ID. Cluster ID is internally generated by Ozone and abstracted from users, who refer to the cluster by service ID. @errose28 you're right. The Cluster ID is internal, and we should not ask the user to provide the Cluster ID. In #4358 the Cluster ID is used internally for Ratis group removal as Cluster ID is used as Ratis Group ID. The validation that is done in `SCMHAManagerImpl#removeSCM` is internal and should never fail for the SCM decommissioning command. @neils-dev we should not get the Cluster ID from the user. Let's split the changes into two PRs. I already have a patch for exposing the SCM decommissioning command in SCM via the RPC call, let me create a PR with that patch. We can refactor this PR for client-side changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
