Tejaskriya commented on code in PR #4538:
URL: https://github.com/apache/ozone/pull/4538#discussion_r1170981099
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/security/S3GetSecretRequest.java:
##########
@@ -168,9 +168,12 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
assignS3SecretValue = null;
}
} else {
- // Found in S3SecretTable.
+ // Found in S3SecretTable. No secret returned.
awsSecret.set(s3SecretValue.getAwsSecret());
- assignS3SecretValue = null;
+ return new S3GetSecretResponse(null,
+ ozoneManager.getS3SecretManager(),
+ createErrorOMResponse(omResponse, new
+
OMException(OMException.ResultCodes.INVALID_REQUEST)));
Review Comment:
Yes, I have made the changes and added a robot test too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
