xichen01 commented on PR #4574:
URL: https://github.com/apache/ozone/pull/4574#issuecomment-1514912342
> @xichen01 Thanks for the changes and sharing the metrics! New additions
look good. I would suggest to remove the old metrics altogether and just keep
the new ones with the suffixes, to avoid duplication and confusion.
>
> e.g.
>
> ```
> csm_metrics_apply_transaction_avg_time{context="dfs",hostname="centos"}
1230705.6332916145
> csm_metrics_apply_transaction_ns_avg_time{context="dfs",hostname="centos"}
1230705.6332916145
> ```
So we just need to directly change the Metric name and needn't keep the old
Metric name?
Do you think the suffix is needed for `ms`, or do we just need to add the
suffix for `ns`? This may need to have a specification for Ozone Metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
