xichen01 commented on code in PR #4572:
URL: https://github.com/apache/ozone/pull/4572#discussion_r1172765276


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java:
##########
@@ -373,6 +373,7 @@ private OzoneConsts() {
 
   // For Multipart upload
   public static final int OM_MULTIPART_MIN_SIZE = 5 * 1024 * 1024;
+  public static final int OM_MULTIPART_MAX_PART_NUMBER = 10000;

Review Comment:
   > @szetszwo I have a compatibility issue b don't know how to solve it 
Suppose we have two versions VOLD and VNEW, VNEW will use a new RocksDB table 
TNEW for `multiupload`, VOLD uses TOLD
   > 
   > The user wants to upload 100 slices. Now the user uploads 50 in VNEW, then 
the cluster rolls back to VOLD, but VOLD does not have the logic to handle the 
`xxKeyInfo` in the new table VNEW, VOLD will not know that the user has 
finished uploading 50 slices, which may have compatibility issues.
   > 
   > To achieve compatibility in the above scenario, it may be necessary to 
write both TOLD and TNEW in the VNEW version, but the issue caused by TOLD is 
still not solved
   
   Is there a good solution to the RocksDB log issue, without breaking 
compatibility, or do we need to tolerate some minor incompatibilities



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to