errose28 commented on code in PR #3967:
URL: https://github.com/apache/ozone/pull/3967#discussion_r1173111498
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/ObjectStore.java:
##########
@@ -125,10 +128,32 @@ public void createVolume(String volumeName, VolumeArgs
volumeArgs)
* @param bucketName - S3 bucket Name.
* @throws IOException - On failure, throws an exception like Bucket exists.
*/
- public void createS3Bucket(String bucketName) throws
- IOException {
+ public void createS3Bucket(String bucketName) throws IOException {
Review Comment:
Moved config validation and string -> enum conversion to the ObjectStore
constructor. Since the client is cached in s3 gateway this will avoid repeated
re-evaluation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
