sumitagrawl commented on code in PR #4591:
URL: https://github.com/apache/ozone/pull/4591#discussion_r1173389987
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ClusterStateEndpoint.java:
##########
@@ -180,6 +196,12 @@ public Response getClusterState() {
.setTotalDatanodes(datanodeDetails.size())
.setHealthyDatanodes(healthyDatanodes)
.setOpenContainers(containerStateCounts.getOpenContainersCount())
+ .setClosingContainers(containerStateCounts.getClosingContainersCount())
+ .setQuasiClosedContainers(
+ containerStateCounts.getQuasiClosedContainersCount())
+ .setClosedContainers(containerStateCounts.getClosedContainersCount())
Review Comment:
IMO, Quasi-Closed can be important state having special meaning. Also
Closing / Deleting if stuck can be identified easily from this perspective.
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ClusterStateEndpoint.java:
##########
@@ -180,6 +196,12 @@ public Response getClusterState() {
.setTotalDatanodes(datanodeDetails.size())
.setHealthyDatanodes(healthyDatanodes)
.setOpenContainers(containerStateCounts.getOpenContainersCount())
+ .setClosingContainers(containerStateCounts.getClosingContainersCount())
+ .setQuasiClosedContainers(
+ containerStateCounts.getQuasiClosedContainersCount())
+ .setClosedContainers(containerStateCounts.getClosedContainersCount())
+ .setDeletingContainers(
+ containerStateCounts.getDeletingContainersCount())
.setDeletedContainers(containerStateCounts.getDeletedContainersCount())
Review Comment:
Deleted Container and Deleting container shows different info ... and not to
be excluded from container count. Only Deleted Container needs to be excluded,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
