aswinshakil commented on PR #4571: URL: https://github.com/apache/ozone/pull/4571#issuecomment-1518110065
> Do we need to change the snapshotInfo status to SNAPSHOT_RECLAIMED here? Do we need to store intermediate result here? Because the Snapshot is removed from the `snapshotInfoTable` in the next step immediately. > I'd like to see unit tests that excercise all the if/else paths in the following methods: > > checkSnapshotReclaimable > checkDirReclaimable > checkKeyReclaimable > handleDirectoryCleanUp > > In addition, I'd like a unit test that confirms that we are correctly starting and stopping within the bucket scope. Sure I will add more tests to this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
