aswinshakil commented on PR #4607: URL: https://github.com/apache/ozone/pull/4607#issuecomment-1518123495
The `snapshotRenamedTable` only tracks the `tableKey` of the directory that was renamed and it is only used by `SnapshotDeletingService`. When a directory is renamed after a snapshot for a bucket is taken. The `SnapshotDeletingService` looks into the `directoryTable` of the previous snapshot, but when the directory is renamed the `tableKey` will be changed. The `snapshotRenamedTable` only acts as reference to check the renamed directories in between snapshot. > For example, what happens if a file is being written under a directory that is renamed? It will file to commit. Has this been considered? This shouldn't be an issue, Everything would go through the original flow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
