dombizita commented on code in PR #4107:
URL: https://github.com/apache/ozone/pull/4107#discussion_r1176606837
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconIncrementalContainerReportHandler.java:
##########
@@ -46,7 +46,7 @@
ReconIncrementalContainerReportHandler.class);
public ReconIncrementalContainerReportHandler(NodeManager nodeManager,
- ContainerManager containerManager, SCMContext scmContext) {
+ ContainerManager containerManager, SCMContext scmContext) {
Review Comment:
I think we should remove this unnecessary change in the class
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconStorageContainerManagerFacade.java:
##########
@@ -165,9 +174,7 @@ public
ReconStorageContainerManagerFacade(OzoneConfiguration conf,
this.eventQueue = new EventQueue();
eventQueue.setSilent(true);
this.scmContext = new SCMContext.Builder()
- .setIsPreCheckComplete(true)
- .setSCM(this)
- .build();
+ .setIsPreCheckComplete(true).setSCM(this).build();
Review Comment:
I think we should remove this unnecessary change in the class (also some
others in this class as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
