dombizita commented on code in PR #4555:
URL: https://github.com/apache/ozone/pull/4555#discussion_r1177628455
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx:
##########
@@ -227,6 +231,9 @@ export class Overview extends
React.Component<Record<string, object>, IOverviewS
<Col xs={24} sm={18} md={12} lg={12} xl={6}>
<OverviewCard loading={loading} title='Keys'
data={keys.toString()} icon='file-text'/>
</Col>
+ <Col xs={24} sm={18} md={12} lg={12} xl={6}>
+ <OverviewCard loading={loading} title='Deleted Containers'
data={deletedContainers !== undefined && deletedContainers.toString()}
icon='delete' />
Review Comment:
I am also not sure why the `deletedContainers !== undefined` check is
needed, non of the above `OverviewCard`s contain it.
why can't we assume that the API response will always return this
information? the backend part of this have been in done in #4440 and I don't
see anything there that would require this check, right @ArafatKhan2198?
btw I tried in a docker cluster and it was working for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
