sodonnel commented on code in PR #4614:
URL: https://github.com/apache/ozone/pull/4614#discussion_r1177660671
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/SCMContainerPlacementRackAware.java:
##########
@@ -338,17 +541,18 @@ private DatanodeDetails chooseNode(List<DatanodeDetails>
excludedNodes,
* @param favoredNodes - list of favoredNodes. It's a hint. Whether the nodes
* are chosen depends on whether they meet the
constrains.
* Can be null.
+ * @param usedNodes - list of the nodes that are already used.
Review Comment:
Ah, I think I see now why we need both. You have chosen - that is what was
select in this call. You have used, which is the existing set of nodes before
the client called into the topology to get more nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
