ArafatKhan2198 commented on PR #4107: URL: https://github.com/apache/ozone/pull/4107#issuecomment-1523399237
> > So after a few discussions with @nandakumar131 The conversation was about adding a trigger to the `IncrementalContainerReportHandler` in order to trigger the `ContainerCountTask` whenever the handler is executed. It was determined that the `ICRReportHandler` will be triggered frequently in a busy cluster, and adding a trigger would put additional load on the cluster. Therefore, the final decision was not to add the trigger to the handler. > > @devmadhuu @dombizita please take a final look at this !! > > during the discussion did you talk about [ReconDeadNodeHandler.java](https://github.com/apache/ozone/pull/4107/files#diff-cf88738ad7edb0171749525ea362b6172a30c36e206e487d0ed916e226c8927d)? do you think it is good to trigger the task beside the periodic runs, is it helping that much in the understanding of container sizes? won't it cause frequent calls in some cases? > > beside this I am fine with your changes, thanks for addressing some of them and answering my questions @ArafatKhan2198! I added a few small comments to remove unnecessary code changes in some classes. I'd like to have @devmadhuu to review it as well as I am not sure if all of his previous comments have been addressed. Thank you for your comment, @dombizita . I appreciate your feedback and concerns regarding the ReconDeadNodeHandler.java and its impact on container size understanding. However, I believe that the frequency of a node going down in a busy cluster is not very high, so triggering the task beside the periodic runs should not significantly impact performance. Additionally, I would like to inform you that @devmadhuu has already discussed with me the pending issues in an offline discussion, and he is good to go on this! I will review your code suggestions and make any necessary changes. Thank you for taking the time to review my code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
