SaketaChalamchala commented on code in PR #4473:
URL: https://github.com/apache/ozone/pull/4473#discussion_r1179427789


##########
hadoop-ozone/dist/src/main/smoketest/s3/objectputget.robot:
##########
@@ -49,7 +49,7 @@ Get object from s3
 Get object with wrong signature
     Pass Execution If          '${SECURITY_ENABLED}' == 'false'    Skip in 
unsecure cluster
     ${result} =                 Execute and Ignore Error   curl -i -H 
'Authorization: AWS scm/[email protected]:asdfqwerty' 
${ENDPOINT_URL}/${BUCKET}/${PREFIX}/putobject/key=value/f1
-                                Should contain             ${result}        
403 Forbidden
+                                Should contain             ${result}        
400 Bad Request

Review Comment:
   @smengcl Thanks for the review. 
   The request here is sending an AWS v2 which we do not support and that's why 
I was returning a "400 - Bad request".  If a "403 - Forbidden" return code 
makes sense here then I can make that change.
   However, for some of the other requests with invalid/incorrect AWS V4 auth 
headers/requests, I'm returning a "400 - Malformed auth header" exception . 
Will modify the error codes and error messages according to the AWS 
documentation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to