prashantpogde commented on code in PR #4511:
URL: https://github.com/apache/ozone/pull/4511#discussion_r1179636683


##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -3655,13 +3655,88 @@
     </description>
   </property>
 
+  <property>
+    <name>ozone.om.snapshot.cache.max.size</name>
+    <value>10</value>
+    <tag>OZONE, OM</tag>
+    <description>
+      Maximum number of entries allowed in the snapshot cache.
+    </description>
+  </property>
+
   <property>
     <name>ozone.om.snapshot.force.full.diff</name>
     <value>false</value>
     <tag>OZONE, OM</tag>
     <description>
-      If true, snapshot diff will always perform full diff (can be slow)
-      without using the optimised DAG based pruning approach
+      Flag to always perform full snapshot diff (can be slow) without using 
the optimised compaction DAG.
+    </description>
+  </property>
+
+  <property>
+    <name>ozone.om.snapshot.diff.max.page.size</name>
+    <value>1000</value>
+    <tag>OZONE, OM</tag>
+    <description>
+       Maximum number of entries to be returned in a single page of snap diff 
report.
+    </description>
+  </property>
+
+  <property>
+    <name>ozone.om.snapshot.diff.thread.pool.size</name>
+    <value>10</value>
+    <tag>OZONE, OM</tag>
+    <description>
+      Maximum numbers of concurrent snapshot diff jobs are allowed.
+    </description>
+  </property>
+
+  <property>
+    <name>ozone.om.snapshot.diff.job.default.wait.time</name>
+    <value>1m</value>
+    <tag>OZONE, OM</tag>
+    <description>
+      Default wait time returned to client to wait before retrying snap diff 
request.
+      Uses millisecond by default when no time unit is specified.
+    </description>
+  </property>
+
+  <property>
+    <name>ozone.om.snapshot.diff.max.jobs.purge.per.task</name>
+    <value>1000</value>
+    <tag>OZONE, OM</tag>
+    <description>

Review Comment:
   Isn't it too high a default value ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to