sodonnel commented on PR #4627: URL: https://github.com/apache/ozone/pull/4627#issuecomment-1527248279
The lock that serialized access to the queue is removed in this PR. Right now, we only have 2 threads that access the queue - the under-rep processor and the over-rep processor. Each of them runs concurrently, and generally accesses only the underRep queue or the overRep queue, so it is probably safe. I wonder if we should make the queue object thread safe via synchronised methods or a lock to ensure that only 1 thread can modify it at a time. It's hard to know how the calling code might change in the future which might result in concurrency issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
