duongkame commented on code in PR #4549:
URL: https://github.com/apache/ozone/pull/4549#discussion_r1181925125
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/proxy/SCMSecurityProtocolFailoverProxyProvider.java:
##########
@@ -289,7 +289,7 @@ public synchronized void close() throws IOException {
for (Map.Entry<String, ProxyInfo<SCMSecurityProtocolPB>> proxy :
scmProxies.entrySet()) {
if (proxy.getValue() != null) {
- RPC.stopProxy(proxy.getValue());
+ RPC.stopProxy(proxy.getValue().proxy);
Review Comment:
Because otherwise, this code throws an error. The error is hidden Previously
because `SCMSecurityProtocolFailoverProxyProvider` is never closed until the
service closes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
