smengcl commented on code in PR #4573:
URL: https://github.com/apache/ozone/pull/4573#discussion_r1182972180
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -2709,15 +2709,18 @@ public List<OmVolumeArgs> listAllVolumes(String prefix,
String prevKey, int
* {@inheritDoc}
*/
@Override
- public List<OmBucketInfo> listBuckets(String volumeName,
- String startKey, String prefix, int maxNumOfBuckets)
+ public List<OmBucketInfo> listBuckets(String volumeName, String startKey,
+ String prefix, int maxNumOfBuckets,
+ boolean isSnapshot)
throws IOException {
boolean auditSuccess = true;
Map<String, String> auditMap = buildAuditMap(volumeName);
auditMap.put(OzoneConsts.START_KEY, startKey);
auditMap.put(OzoneConsts.PREFIX, prefix);
auditMap.put(OzoneConsts.MAX_NUM_OF_BUCKETS,
String.valueOf(maxNumOfBuckets));
+ auditMap.put(OzoneConsts.IS_SNAPSHOT, String.valueOf(isSnapshot));
Review Comment:
`HAS_SNAPSHOT` is better?
```suggestion
auditMap.put(OzoneConsts.HAS_SNAPSHOT, String.valueOf(hasSnapshot));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]